Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 15871005: Avoid N^2 walk placing renderers when building the render tree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding a mitigation for the perf regression to Element::recalcStyle. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/ContainerNodeAlgorithms.cpp ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 1680 matching lines...) Expand 10 before | Expand all | Expand 10 after
1691 if ((change == Force) || (shouldDisplaySeamlesslyWithParent() && (change >= Inherit))) { 1691 if ((change == Force) || (shouldDisplaySeamlesslyWithParent() && (change >= Inherit))) {
1692 // style selector may set this again during recalc 1692 // style selector may set this again during recalc
1693 m_hasNodesWithPlaceholderStyle = false; 1693 m_hasNodesWithPlaceholderStyle = false;
1694 1694
1695 RefPtr<RenderStyle> documentStyle = StyleResolver::styleForDocument( this, m_styleResolver ? m_styleResolver->fontSelector() : 0); 1695 RefPtr<RenderStyle> documentStyle = StyleResolver::styleForDocument( this, m_styleResolver ? m_styleResolver->fontSelector() : 0);
1696 StyleChange ch = Node::diff(documentStyle.get(), renderer()->style() , this); 1696 StyleChange ch = Node::diff(documentStyle.get(), renderer()->style() , this);
1697 if (ch != NoChange) 1697 if (ch != NoChange)
1698 renderer()->setStyle(documentStyle.release()); 1698 renderer()->setStyle(documentStyle.release());
1699 } 1699 }
1700 1700
1701 for (Node* n = firstChild(); n; n = n->nextSibling()) { 1701 for (Node* n = lastChild(); n; n = n->previousSibling()) {
1702 if (!n->isElementNode()) 1702 if (!n->isElementNode())
1703 continue; 1703 continue;
1704 Element* element = toElement(n); 1704 Element* element = toElement(n);
1705 if (shouldRecalcStyle(change, element)) 1705 if (shouldRecalcStyle(change, element))
1706 element->recalcStyle(change); 1706 element->recalcStyle(change);
1707 } 1707 }
1708 1708
1709 if (view()) 1709 if (view())
1710 view()->updateCompositingLayersAfterStyleChange(); 1710 view()->updateCompositingLayersAfterStyleChange();
1711 1711
(...skipping 3509 matching lines...) Expand 10 before | Expand all | Expand 10 after
5221 { 5221 {
5222 return DocumentLifecycleNotifier::create(this); 5222 return DocumentLifecycleNotifier::create(this);
5223 } 5223 }
5224 5224
5225 DocumentLifecycleNotifier* Document::lifecycleNotifier() 5225 DocumentLifecycleNotifier* Document::lifecycleNotifier()
5226 { 5226 {
5227 return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifec ycleNotifier()); 5227 return static_cast<DocumentLifecycleNotifier*>(ScriptExecutionContext::lifec ycleNotifier());
5228 } 5228 }
5229 5229
5230 } // namespace WebCore 5230 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/ContainerNodeAlgorithms.cpp ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698