Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: Source/core/css/resolver/StyleResolverState.cpp

Issue 15871005: Avoid N^2 walk placing renderers when building the render tree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding a mitigation for the perf regression to Element::recalcStyle. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/resolver/StyleResolverState.h ('k') | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 26 matching lines...) Expand all
37 if (m_hasUAAppearance) { 37 if (m_hasUAAppearance) {
38 m_borderData = m_style->border(); 38 m_borderData = m_style->border();
39 m_backgroundData = *m_style->backgroundLayers(); 39 m_backgroundData = *m_style->backgroundLayers();
40 m_backgroundColor = m_style->backgroundColor(); 40 m_backgroundColor = m_style->backgroundColor();
41 } 41 }
42 } 42 }
43 43
44 void StyleResolverState::clear() 44 void StyleResolverState::clear()
45 { 45 {
46 m_element = 0; 46 m_element = 0;
47 m_childIndex = 0;
47 m_styledElement = 0; 48 m_styledElement = 0;
48 m_parentStyle = 0; 49 m_parentStyle = 0;
49 m_parentNode = 0; 50 m_parentNode = 0;
50 m_regionForStyling = 0; 51 m_regionForStyling = 0;
51 m_pendingImageProperties.clear(); 52 m_pendingImageProperties.clear();
52 m_hasPendingShaders = false; 53 m_hasPendingShaders = false;
53 m_pendingSVGDocuments.clear(); 54 m_pendingSVGDocuments.clear();
54 } 55 }
55 56
56 void StyleResolverState::initElement(Element* e) 57 void StyleResolverState::initElement(Element* e, int childIndex)
57 { 58 {
58 m_element = e; 59 m_element = e;
60 m_childIndex = childIndex;
59 m_styledElement = e && e->isStyledElement() ? e : 0; 61 m_styledElement = e && e->isStyledElement() ? e : 0;
60 m_elementLinkState = e ? e->document()->visitedLinkState()->determineLinkSta te(e) : NotInsideLink; 62 m_elementLinkState = e ? e->document()->visitedLinkState()->determineLinkSta te(e) : NotInsideLink;
61 } 63 }
62 64
63 void StyleResolverState::initForStyleResolve(Document* document, Element* e, Ren derStyle* parentStyle, RenderRegion* regionForStyling) 65 void StyleResolverState::initForStyleResolve(Document* document, Element* e, Ren derStyle* parentStyle, RenderRegion* regionForStyling)
64 { 66 {
65 m_regionForStyling = regionForStyling; 67 m_regionForStyling = regionForStyling;
66 68
67 if (e) { 69 if (e) {
68 NodeRenderingContext context(e); 70 NodeRenderingContext context(e);
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 return RenderTheme::focusRingColor(); 145 return RenderTheme::focusRingColor();
144 case CSSValueCurrentcolor: 146 case CSSValueCurrentcolor:
145 return style()->color(); 147 return style()->color();
146 default: 148 default:
147 return colorForCSSValue(valueID); 149 return colorForCSSValue(valueID);
148 } 150 }
149 } 151 }
150 152
151 153
152 } // namespace WebCore 154 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/resolver/StyleResolverState.h ('k') | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698