Add a comment explaining why readline is the only way we can avoid buffering

Add a comment explaining why readline is the only way we can avoid buffering
BUG=163314
R=glider@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202841

[Alexander Potapenko, 2013-05-29 11:07:16]

LGTM

On Wed, May 29, 2013 at 2:31 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Add a comment explaining why readline is the only way we can avoid buffering
> BUG=163314
> R=glider@chromium.org
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/15870005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>   M     tools/valgrind/common.py
>
>
> Index: tools/valgrind/common.py
> ===================================================================
> --- tools/valgrind/common.py    (revision 202543)
> +++ tools/valgrind/common.py    (working copy)
> @@ -55,6 +55,8 @@
>    if timeout > 0:
>      wait_until = time.time() + timeout
>    while p.poll() is None and not did_timeout:
> +    # Have to use readline rather than readlines() or "for line in
> p.stdout:",
> +    # otherwise we get buffered even with bufsize=0.
>      line = p.stdout.readline()
>      while line and not did_timeout:
>        sys.stdout.write(line)
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[commit-bot: I haz the power, 2013-05-29 11:07:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timurrrr@chromium.org/15870005/1

[commit-bot: I haz the power, 2013-05-29 11:38:13]

Change committed as 202841