Update cpplint.py to r104.

Update cpplint.py to r104.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=204686

[mazda, 2013-06-06 12:29:22]

Hello Elliot,

Would it be OK to update cpplint.py in depot_tools?
It's useful for my project if cpplint.py in depot_tools has --root flag feature
added in r103.

Thanks!

[M-A Ruel, 2013-06-06 12:36:44]

rubberstamp lgtm

[Elliot Glaysher, 2013-06-06 17:22:58]

lgtm

(Sorry I forgot to roll this.)

[commit-bot: I haz the power, 2013-06-06 20:26:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/15864011/1

[commit-bot: I haz the power, 2013-06-06 20:28:08]

Presubmit check for 15864011-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (60 files) failed
************* Module drover
E0602:518,18:drover: Undefined variable 'TRUE'


Presubmit checks took 110.4s to calculate.

[commit-bot: I haz the power, 2013-06-06 23:03:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/15864011/1

[commit-bot: I haz the power, 2013-06-06 23:06:29]

Presubmit check for 15864011-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (60 files) failed
************* Module drover
E0602:518,18:drover: Undefined variable 'TRUE'


Presubmit checks took 195.1s to calculate.

[mazda, 2013-06-07 00:59:51]

I cannot reproduce the presubmit error locally.
I tried git cl push but I got "fatal: remote error: Git access forbidden".

maruel/erg, Could any of you submit this CL on behalf of me?

[commit-bot: I haz the power, 2013-06-07 01:03:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/15864011/1

[commit-bot: I haz the power, 2013-06-07 01:04:53]

Change committed as 204686

[M-A Ruel, 2013-06-07 01:06:05]

On 2013/06/07 00:59:51, mazda wrote:
> I cannot reproduce the presubmit error locally.

Someone had broken the presubmit check and a separate CL fixed it.

> I tried git cl push but I got "fatal: remote error: Git access forbidden".

You have to commit via svn but it's fine now, the CL was committed.

[mazda, 2013-06-07 01:07:27]

On 2013/06/07 01:06:05, Marc-Antoine Ruel wrote:
> On 2013/06/07 00:59:51, mazda wrote:
> > I cannot reproduce the presubmit error locally.
> 
> Someone had broken the presubmit check and a separate CL fixed it.
> 
> > I tried git cl push but I got "fatal: remote error: Git access forbidden".
> 
> You have to commit via svn but it's fine now, the CL was committed.

Thanks!

[claudiomdsjr, 2017-07-31 15:25:09]

Hi there,

It seems that this new version has broken all namespace comment mark checks.

https://cs.chromium.org/chromium/tools/depot_tools/cpplint.py?type=cs&q=%22na...

Just get any file in chrome and change the comment in the end from // namespace
X to // namespace Y and you will notice that the new version is not catching the
validation mistake.

Cheers!