Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: src/heap.h

Issue 15864010: Revert "Make more GCs in idle notification handler." because of performance (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2243 matching lines...) Expand 10 before | Expand all | Expand 10 after
2254 } 2254 }
2255 2255
2256 bool IsLowSurvivalRate() { 2256 bool IsLowSurvivalRate() {
2257 return low_survival_rate_period_length_ > 0; 2257 return low_survival_rate_period_length_ > 0;
2258 } 2258 }
2259 2259
2260 void SelectScavengingVisitorsTable(); 2260 void SelectScavengingVisitorsTable();
2261 2261
2262 void StartIdleRound() { 2262 void StartIdleRound() {
2263 mark_sweeps_since_idle_round_started_ = 0; 2263 mark_sweeps_since_idle_round_started_ = 0;
2264 ms_count_at_last_idle_notification_ = ms_count_;
2264 } 2265 }
2265 2266
2266 void FinishIdleRound() { 2267 void FinishIdleRound() {
2267 mark_sweeps_since_idle_round_started_ = kMaxMarkSweepsInIdleRound; 2268 mark_sweeps_since_idle_round_started_ = kMaxMarkSweepsInIdleRound;
2268 scavenges_since_last_idle_round_ = 0; 2269 scavenges_since_last_idle_round_ = 0;
2269 } 2270 }
2270 2271
2271 bool EnoughGarbageSinceLastIdleRound() { 2272 bool EnoughGarbageSinceLastIdleRound() {
2272 return (scavenges_since_last_idle_round_ >= kIdleScavengeThreshold); 2273 return (scavenges_since_last_idle_round_ >= kIdleScavengeThreshold);
2273 } 2274 }
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
2330 2331
2331 Marking marking_; 2332 Marking marking_;
2332 2333
2333 IncrementalMarking incremental_marking_; 2334 IncrementalMarking incremental_marking_;
2334 2335
2335 int number_idle_notifications_; 2336 int number_idle_notifications_;
2336 unsigned int last_idle_notification_gc_count_; 2337 unsigned int last_idle_notification_gc_count_;
2337 bool last_idle_notification_gc_count_init_; 2338 bool last_idle_notification_gc_count_init_;
2338 2339
2339 int mark_sweeps_since_idle_round_started_; 2340 int mark_sweeps_since_idle_round_started_;
2341 int ms_count_at_last_idle_notification_;
2340 unsigned int gc_count_at_last_idle_gc_; 2342 unsigned int gc_count_at_last_idle_gc_;
2341 int scavenges_since_last_idle_round_; 2343 int scavenges_since_last_idle_round_;
2342 2344
2343 // If the --deopt_every_n_garbage_collections flag is set to a positive value, 2345 // If the --deopt_every_n_garbage_collections flag is set to a positive value,
2344 // this variable holds the number of garbage collections since the last 2346 // this variable holds the number of garbage collections since the last
2345 // deoptimization triggered by garbage collection. 2347 // deoptimization triggered by garbage collection.
2346 int gcs_since_last_deopt_; 2348 int gcs_since_last_deopt_;
2347 2349
2348 #ifdef VERIFY_HEAP 2350 #ifdef VERIFY_HEAP
2349 int no_weak_embedded_maps_verification_scope_depth_; 2351 int no_weak_embedded_maps_verification_scope_depth_;
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
3040 DisallowHeapAllocation no_allocation; // i.e. no gc allowed. 3042 DisallowHeapAllocation no_allocation; // i.e. no gc allowed.
3041 3043
3042 private: 3044 private:
3043 DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer); 3045 DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
3044 }; 3046 };
3045 #endif // DEBUG 3047 #endif // DEBUG
3046 3048
3047 } } // namespace v8::internal 3049 } } // namespace v8::internal
3048 3050
3049 #endif // V8_HEAP_H_ 3051 #endif // V8_HEAP_H_
OLDNEW
« no previous file with comments | « no previous file | src/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698