Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 15864010: Revert "Make more GCs in idle notification handler." because of performance (Closed)

Created:
7 years, 6 months ago by ulan
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert "Make more GCs in idle notification handler." because of performance regression. R=jkummerow@chromium.org BUG=246141 Committed: https://code.google.com/p/v8/source/detail?r=14974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.cc View 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 6 months ago (2013-06-06 11:59:08 UTC) #1
Jakob Kummerow
rubberstamp LGTM
7 years, 6 months ago (2013-06-06 12:14:01 UTC) #2
ulan
7 years, 6 months ago (2013-06-06 12:24:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698