Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: Source/core/platform/network/ResourceLoadTiming.h

Issue 15863002: Fix ResourceLoadTiming Resolution Issue 3rd step - remove old fields (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/PerformanceTiming.cpp ('k') | Source/core/platform/network/ResourceLoadTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/network/ResourceLoadTiming.h
diff --git a/Source/core/platform/network/ResourceLoadTiming.h b/Source/core/platform/network/ResourceLoadTiming.h
index 8a36e30f48031cdd6e1581f39c3507678c97195e..983a1dc900aca449f9b2c3cbace653e7a1f33a32 100644
--- a/Source/core/platform/network/ResourceLoadTiming.h
+++ b/Source/core/platform/network/ResourceLoadTiming.h
@@ -83,7 +83,6 @@ public:
// We want to present a unified timeline to Javascript. Using walltime is problematic, because the clock may skew while resources
// load. To prevent that skew, we record a single reference walltime when root document navigation begins. All other times are
// recorded using monotonicallyIncreasingTime(). When a time needs to be presented to Javascript, we build a pseudo-walltime
-#ifdef ENABLE_DOUBLE_RESOURCE_LOAD_TIMING
// using the following equation (requestTime as example):
// pseudo time = document wall reference + (requestTime - document monotonic reference).
double requestTime; // All monotonicallyIncreasingTime() in seconds
@@ -100,28 +99,9 @@ public:
double sslEnd;
double calculateMillisecondDelta(double time) const { return (time - requestTime) * 1000; }
-#else
- // using the following equation:
- // pseudo time = document wall reference + (resource request time - document monotonic reference) + deltaMilliseconds / 1000.0.
- double convertResourceLoadTimeToMonotonicTime(int deltaMilliseconds) const;
-
- double requestTime; // monotonicallyIncreasingTime() when the port started handling this request.
- int proxyStart; // The rest of these are millisecond deltas, using monotonicallyIncreasingTime(), from requestTime.
- int proxyEnd;
- int dnsStart;
- int dnsEnd;
- int connectStart;
- int connectEnd;
- int sendStart;
- int sendEnd;
- int receiveHeadersEnd;
- int sslStart;
- int sslEnd;
-#endif
private:
ResourceLoadTiming()
-#ifdef ENABLE_DOUBLE_RESOURCE_LOAD_TIMING
: requestTime(0)
, proxyStart(0)
, proxyEnd(0)
@@ -134,20 +114,6 @@ private:
, receiveHeadersEnd(0)
, sslStart(0)
, sslEnd(0)
-#else
- : requestTime(0)
- , proxyStart(-1)
- , proxyEnd(-1)
- , dnsStart(-1)
- , dnsEnd(-1)
- , connectStart(-1)
- , connectEnd(-1)
- , sendStart(0)
- , sendEnd(0)
- , receiveHeadersEnd(0)
- , sslStart(-1)
- , sslEnd(-1)
-#endif
{
}
};
« no previous file with comments | « Source/core/page/PerformanceTiming.cpp ('k') | Source/core/platform/network/ResourceLoadTiming.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698