Issue 15862014: Turning on drag and drop from app list to launcher by default

Issue 15862014: Turning on drag and drop from app list to launcher by default (Closed)

Created:
7 years, 6 months ago by Mr4D (OOO till 08-26)

Modified:
7 years, 6 months ago

Reviewers:
James Cook, commit-bot: I haz the power

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turning on drag and drop from app list to launcher by default BUG=242227 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203048

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -18 lines)			Patch
M	ash/ash_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/ash_switches.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ash/launcher/launcher_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_browsertest.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM For more complex features I would encourage using a three-state flag (Default/Enabled/Disabled) and a ...

7 years, 6 months ago (2013-05-29 17:26:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/15862014/1

7 years, 6 months ago (2013-05-29 17:37:46 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=155260

7 years, 6 months ago (2013-05-29 22:20:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/15862014/1

7 years, 6 months ago (2013-05-29 23:14:52 UTC) #5

Message was sent while issue was closed.

Change committed as 203048

Expand Messages | Collapse Messages