chrome/common/extensions/manifest_handlers/externally_connectable.h - Issue 15862011: Restrict the externally_connectable manifest key to effectively a single origin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/externally_connectable.h

Issue 15862011: Restrict the externally_connectable manifest key to effectively a single origin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: yoz Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/manifest_types.json ('k') | chrome/common/extensions/manifest_handlers/externally_connectable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/externally_connectable.h

diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable.h b/chrome/common/extensions/manifest_handlers/externally_connectable.h

index 4e49455e1be139e215c3ed2661a25d707d24f38b..7a8ff61830d6f67e8e21203239b84ea428e8a88b 100644

--- a/chrome/common/extensions/manifest_handlers/externally_connectable.h

+++ b/chrome/common/extensions/manifest_handlers/externally_connectable.h

@@ -23,9 +23,11 @@ namespace extensions {

// Error constants used when parsing the externally_connectable manifest entry.

namespace externally_connectable_errors {

- extern const char kErrorInvalid[];

- extern const char kErrorInvalidMatchPattern[];

- extern const char kErrorInvalidId[];

+extern const char kErrorInvalid[];

+extern const char kErrorInvalidMatchPattern[];

+extern const char kErrorInvalidId[];

+extern const char kErrorTopLevelDomainsNotAllowed[];

+extern const char kErrorWildcardHostsNotAllowed[];

}

// Parses the externally_connectable manifest entry.