Issue 15862011: Restrict the externally_connectable manifest key to effectively a single origin

Issue 15862011: Restrict the externally_connectable manifest key to effectively a single origin (Closed)

Created:
7 years, 6 months ago by not at google - send to devlin

Modified:
7 years, 6 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restrict the externally_connectable manifest key to a single origin per match pattern, by disallowing wildcard hosts and wildcard subdomains of TLDs (com) and effective TLDs (appspot.com). R=yoz@chromium.org BUG=55316 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203009

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : yoz #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -7 lines)			Patch
M	chrome/common/extensions/api/manifest_types.json	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/manifest_handlers/externally_connectable.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/manifest_handlers/externally_connectable.cc	View	1	2 chunks	+47 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc	View	1 2	2 chunks	+70 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/manifest_tests/externally_connectable_error_all_urls.json	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/manifest_tests/externally_connectable_error_effective_tld.json	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/manifest_tests/externally_connectable_error_tld.json	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/manifest_tests/externally_connectable_error_unknown_tld.json	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/manifest_tests/externally_connectable_error_wildcard_host.json	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/manifest_tests/externally_connectable_ids_and_matches.json	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://codereview.chromium.org/15862011/diff/2001/chrome/common/extensions/api/manifest_types.json File chrome/common/extensions/api/manifest_types.json (right): https://codereview.chromium.org/15862011/diff/2001/chrome/common/extensions/api/manifest_types.json#newcode18 chrome/common/extensions/api/manifest_types.json:18: "description": "<p>The URL patterns for web pages that ...

7 years, 6 months ago (2013-05-29 00:14:05 UTC) #2

not at google - send to devlin

https://codereview.chromium.org/15862011/diff/2001/chrome/common/extensions/api/manifest_types.json File chrome/common/extensions/api/manifest_types.json (right): https://codereview.chromium.org/15862011/diff/2001/chrome/common/extensions/api/manifest_types.json#newcode18 chrome/common/extensions/api/manifest_types.json:18: "description": "<p>The URL patterns for web pages that are ...

7 years, 6 months ago (2013-05-29 20:52:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/15862011/8001

7 years, 6 months ago (2013-05-29 20:52:17 UTC) #4

Message was sent while issue was closed.

Change committed as 203009

Expand Messages | Collapse Messages