Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 15861013: [Telemetry] Fix TabConsoleTest.testConsoleOutputStream. (Closed)

Created:
7 years, 7 months ago by tonyg
Modified:
7 years, 7 months ago
Reviewers:
tonyg, dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix TabConsoleTest.testConsoleOutputStream. This apparently broke when the NTP started producing console output. This patch fixes the test by ignoring console output in the NTP. BUG=243533 TEST=tools/telemetry/run_tests TabConsoleTest NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/chrome/inspector_console.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tonyg
7 years, 7 months ago (2013-05-24 19:27:16 UTC) #1
dtu
lgtm
7 years, 7 months ago (2013-05-24 19:30:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/15861013/1
7 years, 7 months ago (2013-05-24 19:32:42 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 19:32:51 UTC) #4
Message was sent while issue was closed.
Change committed as 202145

Powered by Google App Engine
This is Rietveld 408576698