Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 15861012: Polish new dialog style layout and sizing. (Closed)

Created:
7 years, 7 months ago by msw
Modified:
7 years, 6 months ago
CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org
Visibility:
Public.

Description

Polish new dialog style layout and sizing. Fix values of top/left dialog title insets, add explicit bottom inset. Fix dialog inset and preferred size calculations, and layout for title/extra. ( long titles were not being accounted for, and getting cut off ) Add a title bar extra view to the views examples dialog. See before/after/spec pics at http://crbug.com/242284#c14 BUG=242284, 240730, 166075 TEST=New dialog style looks good, no titles cut off. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202479

Patch Set 1 #

Patch Set 2 : Remove long title example debugging code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +31 lines, -18 lines 0 comments Download
M ui/views/examples/widget_example.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 7 months ago (2013-05-24 18:55:51 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-24 20:25:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15861012/1001
7 years, 7 months ago (2013-05-24 20:27:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=153948
7 years, 7 months ago (2013-05-25 05:13:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15861012/1001
7 years, 7 months ago (2013-05-25 18:06:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154003
7 years, 7 months ago (2013-05-25 22:55:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15861012/1001
7 years, 7 months ago (2013-05-27 19:39:28 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 7 months ago (2013-05-28 00:40:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15861012/1001
7 years, 7 months ago (2013-05-28 01:26:58 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 01:56:18 UTC) #10
Message was sent while issue was closed.
Change committed as 202479

Powered by Google App Engine
This is Rietveld 408576698