Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 15858006: Tag length of FixedArrayBase and smi-array[x] as smi representation (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Tag length of FixedArrayBase and smi-array[x] as smi representation R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14778

Patch Set 1 #

Patch Set 2 : Split check-smi-and-return from check-smi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -16 lines) Patch
M src/arm/lithium-arm.h View 1 3 chunks +14 lines, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 3 chunks +14 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 1 3 chunks +14 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-23 14:05:15 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-23 14:37:51 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-23 14:38:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698