Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 15858003: Merged r14185 into 3.14 branch. (Closed)

Created:
7 years, 7 months ago by Yang
Modified:
7 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Merged r14185 into 3.14 branch. Add an option to dump core when an uncaught exception is thrown. This is done as a courtesy to node.js, as its current stable version (0.10) relies on V8 version 3.14.5. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
7 years, 7 months ago (2013-05-23 10:46:58 UTC) #1
ulan
lgtm
7 years, 7 months ago (2013-05-23 10:47:39 UTC) #2
Yang
Committed patchset #1 manually as r14772 (presubmit successful).
7 years, 7 months ago (2013-05-23 10:49:25 UTC) #3
aredridel
V8 folks (and ulan especially), we love you. <3, Node folks.
7 years, 7 months ago (2013-05-23 20:55:00 UTC) #4
tjfontaine
On 2013/05/23 10:49:25, Yang wrote: > Committed patchset #1 manually as r14772 (presubmit successful). First ...
7 years, 7 months ago (2013-05-23 20:56:31 UTC) #5
Yang
7 years, 7 months ago (2013-05-24 08:52:21 UTC) #6
Message was sent while issue was closed.
On 2013/05/23 20:56:31, tj.fontaine wrote:
> On 2013/05/23 10:49:25, Yang wrote:
> > Committed patchset #1 manually as r14772 (presubmit successful).
> First off thanks for this backport!
> 
> Currently though it doesn't compile because the signature for
> GetLocalizedMessage changed, as I read it it should only need message_obj

Thanks! I fixed the issue in 3.14.5.10.

Is there any other V8 branch this patch needs to be backmerged to?

Powered by Google App Engine
This is Rietveld 408576698