Issue 15857002: [Quota][Clean up] Simplify usage aggregator in ClientUsageTracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15857002: [Quota][Clean up] Simplify usage aggregator in ClientUsageTracker (Closed)

Created:
7 years, 7 months ago by tzik

Modified:
7 years, 6 months ago

Reviewers:
kinuko, commit-bot: I haz the power

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Quota][Clean up] Simplify usage aggregator in ClientUsageTracker This CL replaces GatherUsageTask in ClientUsageTracker with Callback-based usage accumulation. BUG=220029 TEST=existing QuotaManagerTest test and UsageTrackerTest. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202405

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : reorder, move simple functions to anonymous namespace #

Patch Set 6 : test fix #

Patch Set 7 : +comment #

Patch Set 8 : buildfix for android #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -302 lines)			Patch
	M	webkit/quota/usage_tracker.h	View	1 2 3 4	6 chunks	+43 lines, -20 lines	0 comments	Download
	M	webkit/quota/usage_tracker.cc	View	1 2 3 4 5 6 7	18 chunks	+151 lines, -282 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15857002/25001

7 years, 6 months ago (2013-05-27 06:50:20 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 6 months ago (2013-05-27 07:06:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/15857002/38001

7 years, 6 months ago (2013-05-27 08:12:55 UTC) #5

Message was sent while issue was closed.

Change committed as 202405

Expand Messages | Collapse Messages