Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 15850005: Declare trivial methods as const (Closed)

Created:
7 years, 7 months ago by Eric Willigers
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, Rik, adamk+blink_chromium.org, jchaffraix+rendering, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Declare trivial methods as const BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/core/page/ContentSecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Julien - ping for review
Apologies for the delay, was gardening and didn't check my incoming reviews. lgtm!
7 years, 6 months ago (2013-05-29 19:47:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-05-29 19:48:07 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7508
7 years, 6 months ago (2013-05-29 22:29:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-05-30 00:15:49 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7583
7 years, 6 months ago (2013-05-30 04:06:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-05-30 21:41:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7889
7 years, 6 months ago (2013-05-31 01:13:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-05-31 02:14:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7945
7 years, 6 months ago (2013-05-31 04:41:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-05-31 04:51:42 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7986
7 years, 6 months ago (2013-05-31 08:07:43 UTC) #11
Julien - ping for review
The cq seems stuck, feel free to land manually in this case (or ask me ...
7 years, 6 months ago (2013-05-31 20:34:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-06-01 07:39:39 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8270
7 years, 6 months ago (2013-06-01 09:32:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/15850005/1
7 years, 6 months ago (2013-06-02 18:48:46 UTC) #15
commit-bot: I haz the power
7 years, 6 months ago (2013-06-02 21:22:56 UTC) #16
Message was sent while issue was closed.
Change committed as 151611

Powered by Google App Engine
This is Rietveld 408576698