Use sudo in remoting init.d script to get a clean per-user environment

Use sudo in remoting init.d script to get a clean per-user environment

Using 'sudo' to start the per-user process ensures the
ulimits (and hopefully other environment settings) are set
properly.

BUG=169802
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205486

[Lambros, 2013-06-06 22:00:06]

It seems a simple enough fix, but not completely without risk :) WDYT? In
particular, the '-i' sudo option will set up a login environment, but this will
also run the user's .profile script. Using '-b' will put this in the background,
so it won't hold up other system services from starting.

[Jamie, 2013-06-06 22:13:04]

lgtm

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
File remoting/host/installer/linux/debian/chrome-remote-desktop.init (right):

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:59:
shell="$(getent passwd "$user" | cut -d: -f7)"
Remove this line?

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:60: sudo -i -b
-u "$user" start-stop-daemon --exec "$exec" --start -- "$@"
According to the man page, the command should follow -i, so please make -i the
last option on the command-line.

[Sergey Ulanov, 2013-06-06 22:22:43]

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
File remoting/host/installer/linux/debian/chrome-remote-desktop.init (right):

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:60: sudo -i -b
-u "$user" start-stop-daemon --exec "$exec" --start -- "$@"
Why do you still need start-stop-daemon here? 
run_and_ignore_error() is used not only to start the daemon. E.g. do_restart()
expects it to stop service synchronously, so using -i in that case is not right
thing to do.

[Lambros, 2013-06-07 01:22:16]

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
File remoting/host/installer/linux/debian/chrome-remote-desktop.init (right):

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:59:
shell="$(getent passwd "$user" | cut -d: -f7)"
On 2013/06/06 22:13:04, Jamie wrote:
> Remove this line?

Done.

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:60: sudo -i -b
-u "$user" start-stop-daemon --exec "$exec" --start -- "$@"
On 2013/06/06 22:13:04, Jamie wrote:
> According to the man page, the command should follow -i, so please make -i the
> last option on the command-line.

Done.

https://codereview.chromium.org/15848019/diff/1/remoting/host/installer/linux...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:60: sudo -i -b
-u "$user" start-stop-daemon --exec "$exec" --start -- "$@"
On 2013/06/06 22:22:44, Sergey Ulanov wrote:
> Why do you still need start-stop-daemon here? 
> run_and_ignore_error() is used not only to start the daemon. E.g. do_restart()
> expects it to stop service synchronously, so using -i in that case is not
right
> thing to do.
Yeah, I don't think start-stop-daemon does anything for us. The Python script
already self-daemonizes and implements the logic for looking up existing
processes.

[Sergey Ulanov, 2013-06-07 20:51:21]

lgtm when my comments are addressed

https://codereview.chromium.org/15848019/diff/6001/remoting/host/installer/li...
File remoting/host/installer/linux/debian/chrome-remote-desktop.init (right):

https://codereview.chromium.org/15848019/diff/6001/remoting/host/installer/li...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:49: # Usage:
run_and_ignore_error [-l] user program [args...]
maybe better to use  "--login" instead of -l.

https://codereview.chromium.org/15848019/diff/6001/remoting/host/installer/li...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:50: #   -l: Run
program in a clean login shell (which requires backgrounding, since
the backgrouding details is important here, so maybe better to move it out of
parentheses.

[Lambros, 2013-06-11 01:41:02]

https://codereview.chromium.org/15848019/diff/6001/remoting/host/installer/li...
File remoting/host/installer/linux/debian/chrome-remote-desktop.init (right):

https://codereview.chromium.org/15848019/diff/6001/remoting/host/installer/li...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:49: # Usage:
run_and_ignore_error [-l] user program [args...]
On 2013/06/07 20:51:21, Sergey Ulanov wrote:
> maybe better to use  "--login" instead of -l.

Done.

https://codereview.chromium.org/15848019/diff/6001/remoting/host/installer/li...
remoting/host/installer/linux/debian/chrome-remote-desktop.init:50: #   -l: Run
program in a clean login shell (which requires backgrounding, since
On 2013/06/07 20:51:21, Sergey Ulanov wrote:
> the backgrouding details is important here, so maybe better to move it out of
> parentheses.

Done.

[commit-bot: I haz the power, 2013-06-11 01:42:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/15848019/1...

[commit-bot: I haz the power, 2013-06-11 10:56:20]

Change committed as 205486