Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 15848002: Omit smi-check for write-barrier unless tagged. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Omit smi-check for write-barrier unless tagged. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M src/arm/stub-cache-arm.cc View 6 chunks +16 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 6 chunks +16 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 6 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-23 09:13:20 UTC) #1
mvstanton
That is good that you can eliminate that. Looks good. lgtm.
7 years, 7 months ago (2013-05-23 09:16:41 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-23 09:18:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698