Issue 15846013: [Telemetry] Fix TestPageSet.testSimpleSet on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15846013: [Telemetry] Fix TestPageSet.testSimpleSet on windows. (Closed)

Created:
7 years, 7 months ago by tonyg

Modified:
7 years, 7 months ago

Reviewers:
dtu, tonyg, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Fix TestPageSet.testSimpleSet on windows. 1. You cannot open a file for writing and reading at the same time on windows. So close the writing file before opening it for reading. 2. Fix json backslash escaping issue. BUG=243537 TEST=python tools\telemetry\run_tests TestPageSet.testSimpleSet NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202126

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	tools/telemetry/telemetry/page/page_set_unittest.py	View		1 chunk	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/15846013/1

7 years, 7 months ago (2013-05-24 18:11:35 UTC) #3

Message was sent while issue was closed.

Change committed as 202126

Expand Messages | Collapse Messages