Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 15843006: Random clean up in c/b/cros/drive. (Closed)

Created:
7 years, 7 months ago by kinaba
Modified:
7 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Random clean up in c/b/cros/drive. Use utility function for boilerplate test code. Fix typos. Remove resolved TODO comments. Remove unused include, etc. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -45 lines) Patch
M chrome/browser/chromeos/drive/drive_file_stream_reader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_interface.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 7 chunks +7 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/webkit_file_stream_reader_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/google_apis/test_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
7 years, 7 months ago (2013-05-27 03:11:01 UTC) #1
hashimoto
nice clean up. lgtm
7 years, 7 months ago (2013-05-27 03:18:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/15843006/1
7 years, 7 months ago (2013-05-27 03:29:40 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 07:15:58 UTC) #4
Message was sent while issue was closed.
Change committed as 202377

Powered by Google App Engine
This is Rietveld 408576698