Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: ipc/param_traits_macros.h

Issue 15841011: Implement off-the-wire validation scheme for enum types. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add () around macro parameter. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/param_traits_log_macros.h ('k') | ipc/param_traits_read_macros.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_PARAM_TRAITS_MACROS_H_ 5 #ifndef IPC_PARAM_TRAITS_MACROS_H_
6 #define IPC_PARAM_TRAITS_MACROS_H_ 6 #define IPC_PARAM_TRAITS_MACROS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 // Traits generation for structs. 10 // Traits generation for structs.
11 #define IPC_STRUCT_TRAITS_BEGIN(struct_name) \ 11 #define IPC_STRUCT_TRAITS_BEGIN(struct_name) \
12 namespace IPC { \ 12 namespace IPC { \
13 template <> \ 13 template <> \
14 struct IPC_MESSAGE_EXPORT ParamTraits<struct_name> { \ 14 struct IPC_MESSAGE_EXPORT ParamTraits<struct_name> { \
15 typedef struct_name param_type; \ 15 typedef struct_name param_type; \
16 static void Write(Message* m, const param_type& p); \ 16 static void Write(Message* m, const param_type& p); \
17 static bool Read(const Message* m, PickleIterator* iter, param_type* p); \ 17 static bool Read(const Message* m, PickleIterator* iter, param_type* p); \
18 static void Log(const param_type& p, std::string* l); \ 18 static void Log(const param_type& p, std::string* l); \
19 }; \ 19 }; \
20 } 20 }
21 21
22 #define IPC_STRUCT_TRAITS_MEMBER(name) 22 #define IPC_STRUCT_TRAITS_MEMBER(name)
23 #define IPC_STRUCT_TRAITS_PARENT(type) 23 #define IPC_STRUCT_TRAITS_PARENT(type)
24 #define IPC_STRUCT_TRAITS_END() 24 #define IPC_STRUCT_TRAITS_END()
25 25
26 // Traits generation for enums. 26 // Convenience macro for defining enumerated type traits for types which are
27 #define IPC_ENUM_TRAITS(enum_name) \ 27 // not range-checked by the IPC system. The author of the message handlers
28 // is responsible for all validation. This macro should not need to be
29 // subsequently redefined.
30 #define IPC_ENUM_TRAITS(type) \
31 IPC_ENUM_TRAITS_VALIDATE(type, true)
32
33 // Convenience macro for defining enumerated type traits for types which are
34 // range-checked by the IPC system to be in the range of 0..maxvalue inclusive.
35 // This macro should not need to be subsequently redefined.
36 #define IPC_ENUM_TRAITS_MAX_VALUE(type, maxvalue) \
37 IPC_ENUM_TRAITS_MIN_MAX_VALUE(type, 0, maxvalue)
38
39 // Convenience macro for defining enumerated type traits for types which are
40 // range-checked by the IPC system to be in the range of minvalue..maxvalue
41 // inclusive. This macro should not need to be subsequently redefined.
42 #define IPC_ENUM_TRAITS_MIN_MAX_VALUE(type, minvalue, maxvalue) \
43 IPC_ENUM_TRAITS_VALIDATE(type, (value >= (minvalue) && value <= (maxvalue)))
44
45 // Traits generation for enums. This macro may be redefined later.
46 #define IPC_ENUM_TRAITS_VALIDATE(enum_name, validation_expression) \
28 namespace IPC { \ 47 namespace IPC { \
29 template <> \ 48 template <> \
30 struct IPC_MESSAGE_EXPORT ParamTraits<enum_name> { \ 49 struct IPC_MESSAGE_EXPORT ParamTraits<enum_name> { \
31 typedef enum_name param_type; \ 50 typedef enum_name param_type; \
32 static void Write(Message* m, const param_type& p); \ 51 static void Write(Message* m, const param_type& p); \
33 static bool Read(const Message* m, PickleIterator* iter, param_type* p); \ 52 static bool Read(const Message* m, PickleIterator* iter, param_type* p); \
34 static void Log(const param_type& p, std::string* l); \ 53 static void Log(const param_type& p, std::string* l); \
35 }; \ 54 }; \
36 } 55 }
37 56
38 #endif // IPC_PARAM_TRAITS_MACROS_H_ 57 #endif // IPC_PARAM_TRAITS_MACROS_H_
39 58
OLDNEW
« no previous file with comments | « ipc/param_traits_log_macros.h ('k') | ipc/param_traits_read_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698