Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 15841007: Remove HCheckSmi, LCheckSmi and rename LCheckSmiAndReturn to LCheckSmi. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Remove HCheckSmi, LCheckSmi and rename LCheckSmiAndReturn to LCheckSmi. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14816

Patch Set 1 : #

Patch Set 2 : Use ForceRepresentation rather than directly inserting HChange #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -140 lines) Patch
M src/arm/lithium-arm.h View 3 chunks +1 line, -14 lines 0 comments Download
M src/arm/lithium-arm.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 4 chunks +6 lines, -12 lines 0 comments Download
M src/hydrogen-instructions.h View 1 3 chunks +2 lines, -25 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +1 line, -14 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +1 line, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-27 08:40:29 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-27 09:57:15 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-27 09:58:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698