Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 15841006: ash: Add UMA action metrics for Ctrl-Shift-Q (Closed)

Created:
7 years, 7 months ago by James Cook
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, MAD, sadrul, jar (doing other things), ben+watch_chromium.org, jwd
Visibility:
Public.

Description

ash: Add UMA action metrics for Ctrl-Shift-Q BUG=none TEST=uma.googleplex.com gains a user action entry from Accel_Exit_First_Q and Accel_Exit_Second_Q R=sschmitz@chromium.org TBR=sschmitz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/accelerators/exit_warning_handler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ash/shell_delegate.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/actions/chromeactions.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
PTAL - This should give us some idea about how often people only hit Ctrl-Shift-Q ...
7 years, 7 months ago (2013-05-25 13:23:02 UTC) #1
James Cook
On 2013/05/25 13:23:02, James Cook (Chromium) wrote: > PTAL - This should give us some ...
7 years, 7 months ago (2013-05-27 11:45:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/15841006/1
7 years, 7 months ago (2013-05-27 11:46:07 UTC) #3
commit-bot: I haz the power
Change committed as 202421
7 years, 7 months ago (2013-05-27 14:23:56 UTC) #4
jar (doing other things)
Please add changes for tools/metrics/histograms/histograms.xml. It is helpful for to have both together when we ...
7 years, 7 months ago (2013-05-27 16:57:46 UTC) #5
James Cook
jar/alexei - I'm planning to compare this keyboard shortcut to other keyboard shortcuts like Accel_LockScreen_L ...
7 years, 6 months ago (2013-05-28 15:40:48 UTC) #6
Alexei Svitkine (slow)
7 years, 6 months ago (2013-05-28 15:47:27 UTC) #7
Message was sent while issue was closed.
This is fine.

Since these are UMA actions and not histograms, no changes to histograms.xml are
necessary.

lgtm

Powered by Google App Engine
This is Rietveld 408576698