Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3785)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm

Issue 15840012: Fix AutofillMetricsTest.QualityMetrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: extend Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm
index f6f5165ff03df6fc97989d4297b477a1913fd77a..888087f64754e25329083c26a7d172cefc87a2dc 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm
@@ -10,6 +10,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
+#include "components/autofill/browser/autofill_common_test.h"
#include "components/autofill/common/form_data.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_view.h"
@@ -77,6 +78,9 @@ class AutofillDialogCocoaBrowserTest : public InProcessBrowserTest {
virtual ~AutofillDialogCocoaBrowserTest() {}
virtual void SetUpOnMainThread() OVERRIDE {
+ // Ensure Mac OS X does not pop up a modal dialog for the Address Book.
+ autofill::test::DisableSystemServices(browser()->profile());
+
FormFieldData field;
field.autocomplete_attribute = "cc-number";
FormData form_data;
@@ -103,9 +107,8 @@ class AutofillDialogCocoaBrowserTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(AutofillDialogCocoaBrowserTest);
};
-// The following test fails under ASAN. Disabling until root cause is found.
-// This can pop up a "browser_tests would like access to your Contacts" dialog.
-// See also http://crbug.com/234008.
+// The following test fails under ASAN due to a read-after-free.
+// http://crbug.com/234008
#if defined(ADDRESS_SANITIZER)
#define MAYBE_DisplayUI DISABLED_DisplayUI
#else
« no previous file with comments | « no previous file | components/autofill/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698