Issue 15840012: Fix AutofillMetricsTest.QualityMetrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15840012: Fix AutofillMetricsTest.QualityMetrics. (Closed)

Created:
7 years, 7 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
groby-ooo-7-16, Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix AutofillDialogCocoaBrowserTest, AutofillMetricsTest. BUG=242659, 234008 TEST=Mac 64 tester bot doesn't time out Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202659

Patch Set 1 #

Patch Set 2 : extend #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm	View	1	3 chunks	+6 lines, -3 lines	0 comments	Download
	M	components/autofill/browser/autofill_metrics_unittest.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

groby: for review; this is more of the same estade: OWNER stamp, please This test ...

7 years, 7 months ago (2013-05-26 00:48:13 UTC) #1

Avi (use Gerrit)

OK, so the other fix got rolled out because it didn't fix what turns out ...

7 years, 7 months ago (2013-05-26 15:54:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/15840012/6001

7 years, 6 months ago (2013-05-28 19:30:36 UTC) #5

Message was sent while issue was closed.

Change committed as 202659

Expand Messages | Collapse Messages