Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15840002: CSS entry for Dialog element should be in RenderTheme::extraDefaultStyleSheet (Closed)

Created:
7 years, 7 months ago by riju_
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

CSS entry for Dialog element should be in RenderTheme::extraDefaultStyleSheet core/rendering/css/html.css still contains the css for the dialog element. If the runtime flag is off, feature detection in web sites will fail. This rule should be added in RenderTheme::extraDefaultStyleSheet depending on the runtime flag. R= BUG=243225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151171

Patch Set 1 #

Total comments: 3

Patch Set 2 : tkent's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M Source/core/css/html.css View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
riju_
7 years, 7 months ago (2013-05-23 08:47:32 UTC) #1
keishi
I'm not an owner, but lgtm. https://codereview.chromium.org/15840002/diff/1/Source/core/rendering/RenderTheme.cpp File Source/core/rendering/RenderTheme.cpp (right): https://codereview.chromium.org/15840002/diff/1/Source/core/rendering/RenderTheme.cpp#newcode459 Source/core/rendering/RenderTheme.cpp:459: if (!RuntimeEnabledFeatures::dataListElementEnabled() && ...
7 years, 7 months ago (2013-05-23 09:05:14 UTC) #2
tkent
https://codereview.chromium.org/15840002/diff/1/Source/core/rendering/RenderTheme.cpp File Source/core/rendering/RenderTheme.cpp (right): https://codereview.chromium.org/15840002/diff/1/Source/core/rendering/RenderTheme.cpp#newcode461 Source/core/rendering/RenderTheme.cpp:461: DEFINE_STATIC_LOCAL(StringBuilder, runtimeCSS, ()); Do not make this static. runtimeCSS ...
7 years, 7 months ago (2013-05-23 10:07:55 UTC) #3
riju_
7 years, 7 months ago (2013-05-24 13:05:32 UTC) #4
tkent
lgtm
7 years, 7 months ago (2013-05-25 00:56:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/15840002/11001
7 years, 7 months ago (2013-05-25 00:56:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6631
7 years, 7 months ago (2013-05-25 02:44:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/15840002/11001
7 years, 7 months ago (2013-05-25 10:29:42 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6664
7 years, 7 months ago (2013-05-25 13:45:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/15840002/11001
7 years, 7 months ago (2013-05-26 20:47:10 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6715
7 years, 7 months ago (2013-05-27 00:34:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/15840002/11001
7 years, 7 months ago (2013-05-27 00:43:40 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6748
7 years, 7 months ago (2013-05-27 03:41:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/15840002/11001
7 years, 7 months ago (2013-05-27 03:56:50 UTC) #14
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 04:29:48 UTC) #15
Message was sent while issue was closed. 
Change committed as 151171

Powered by Google App Engine
This is Rietveld 408576698