Issue 15839006: Android: removes pylib.constants.CHROME_DIR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15839006: Android: removes pylib.constants.CHROME_DIR. (Closed)

Created:
7 years, 6 months ago by bulach

Modified:
7 years, 6 months ago

Reviewers:
frankf, Sami, Paweł Hajdan Jr.

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: removes pylib.constants.CHROME_DIR. Follow up from crrev.com/204357, it has now rolled downstream so it's safe to remove the constant. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204812

Patch Set 1 #

Patch Set 2 : find_bugs #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
M	build/android/device_status_check.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/android/pylib/constants.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bulach

ptal. in the future, let's ensure such deadlock doesn't happen: delaying the webgl tests due ...

7 years, 6 months ago (2013-06-06 09:56:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/15839006/3001

7 years, 6 months ago (2013-06-07 08:36:06 UTC) #5

Message was sent while issue was closed.

Change committed as 204812

Expand Messages | Collapse Messages