Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 15827009: linux_aura: Close window when the OS requests it. (Closed)

Created:
7 years, 6 months ago by Elliot Glaysher
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Close window when the OS requests it. Alt-F4 key events are handled by the window manager, who then sends an X11 message telling us that we should close. This used to be hooked up, but it looks like it broke when we merged with the crossplatform DesktopNativeWidgetAura code that we also use on Windows. BUG=176783 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202758

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add paired removal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
7 years, 6 months ago (2013-05-28 21:44:03 UTC) #1
sky
https://codereview.chromium.org/15827009/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right): https://codereview.chromium.org/15827009/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc#newcode238 ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:238: root_window_->AddRootWindowObserver(this); I like things that are balanced. Can you ...
7 years, 6 months ago (2013-05-29 00:05:31 UTC) #2
Elliot Glaysher
https://codereview.chromium.org/15827009/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc File ui/views/widget/desktop_aura/desktop_native_widget_aura.cc (right): https://codereview.chromium.org/15827009/diff/1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc#newcode238 ui/views/widget/desktop_aura/desktop_native_widget_aura.cc:238: root_window_->AddRootWindowObserver(this); On 2013/05/29 00:05:31, sky wrote: > I like ...
7 years, 6 months ago (2013-05-29 00:11:05 UTC) #3
sky
LGTM
7 years, 6 months ago (2013-05-29 00:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/15827009/19001
7 years, 6 months ago (2013-05-29 00:12:56 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 02:59:23 UTC) #6
Message was sent while issue was closed.
Change committed as 202758

Powered by Google App Engine
This is Rietveld 408576698