Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5751)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 15825008: Remove the event URL security check out of the renderer and into the browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add self check Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/dispatcher.h ('k') | chrome/renderer/extensions/extension_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index ddb1086b0ccedf286f5d498dd7d0df8205da92c4..95b1284ac16dbeae34215c2f246ab99095f43488 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -552,7 +552,6 @@ void Dispatcher::OnSetChannel(int channel) {
void Dispatcher::OnMessageInvoke(const std::string& extension_id,
const std::string& function_name,
const base::ListValue& args,
- const GURL& event_url,
bool user_gesture) {
scoped_ptr<WebScopedUserGesture> web_user_gesture;
if (user_gesture) {
@@ -560,7 +559,7 @@ void Dispatcher::OnMessageInvoke(const std::string& extension_id,
}
v8_context_set_.DispatchChromeHiddenMethod(
- extension_id, function_name, args, NULL, event_url);
+ extension_id, function_name, args, NULL);
// Reset the idle handler each time there's any activity like event or message
// dispatch, for which Invoke is the chokepoint.
@@ -1359,7 +1358,7 @@ void Dispatcher::OnSuspend(const std::string& extension_id) {
args.Set(0, new base::StringValue(kOnSuspendEvent));
args.Set(1, new base::ListValue());
v8_context_set_.DispatchChromeHiddenMethod(
- extension_id, kEventDispatchFunction, args, NULL, GURL());
+ extension_id, kEventDispatchFunction, args, NULL);
RenderThread::Get()->Send(new ExtensionHostMsg_SuspendAck(extension_id));
}
@@ -1369,7 +1368,7 @@ void Dispatcher::OnCancelSuspend(const std::string& extension_id) {
args.Set(0, new base::StringValue(kOnSuspendCanceledEvent));
args.Set(1, new base::ListValue());
v8_context_set_.DispatchChromeHiddenMethod(
- extension_id, kEventDispatchFunction, args, NULL, GURL());
+ extension_id, kEventDispatchFunction, args, NULL);
}
Feature::Context Dispatcher::ClassifyJavaScriptContext(
« no previous file with comments | « chrome/renderer/extensions/dispatcher.h ('k') | chrome/renderer/extensions/extension_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698