Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 15825003: This CL removes an invalid CSS property value and replaces it with the initial value. (Closed)

Created:
7 years, 7 months ago by umar.hansa
Modified:
7 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

This CL removes an invalid CSS property value and replaces it with the initial value. This appears on the new tab page. BUG=243203 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202826

Patch Set 1 #

Patch Set 2 : Remove the invalid line of CSS as 'default' is not a valid property value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/ntp4/tile_page.css View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 7 months ago (2013-05-23 06:36:35 UTC) #1
umar.hansa
dbeam: Please review when you get a chance, thanks.
7 years, 7 months ago (2013-05-23 06:50:02 UTC) #2
umar.hansa
The invalid line of CSS has been removed.
7 years, 7 months ago (2013-05-25 14:06:35 UTC) #3
Dan Beam
lgtm like I mentioned in the other CL -- let's just do the safest thing ...
7 years, 6 months ago (2013-05-29 03:15:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/umar.hansa@gmail.com/15825003/4001
7 years, 6 months ago (2013-05-29 03:15:36 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 08:48:19 UTC) #6
Message was sent while issue was closed.
Change committed as 202826

Powered by Google App Engine
This is Rietveld 408576698