Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 15824003: check texture is not NULL to aovid segmentation fault. (Closed)

Created:
7 years, 6 months ago by yunchao
Modified:
7 years, 6 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

check texture is not NULL to aovid segmentation fault. If the texture created by GrLockAndRefCachedBitmapTexture() is NULL, ColorTableEffect::Create will cause segmentation fault by GrAssert in src/gpu/GrTextureAccess.cpp. The simple patch checked texture to avoid segment fault, and returned a NULL effect to the caller. The caller will handle NULL effect, for example, it will set default effect. Committed: http://code.google.com/p/skia/source/detail?r=9287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/effects/SkTableColorFilter.cpp View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yunchao
7 years, 6 months ago (2013-05-28 13:01:48 UTC) #1
bsalomon
On 2013/05/28 13:01:48, yunchao.he wrote: lgtm. Thanks!
7 years, 6 months ago (2013-05-28 13:06:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/15824003/1
7 years, 6 months ago (2013-05-28 13:06:22 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 13:13:57 UTC) #4
Message was sent while issue was closed.
Change committed as 9287

Powered by Google App Engine
This is Rietveld 408576698