Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 15823004: Remove lines of CSS which have invalid property values. (Closed)

Created:
7 years, 7 months ago by umar.hansa
Modified:
7 years, 6 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove lines of CSS which have invalid property values. BUG=243208 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202799

Patch Set 1 #

Patch Set 2 : Removing the lines of CSS which would have been ignored anyway (due to their invalid property value… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/webui/resources/css/bubble.css View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/css/expandable_bubble.css View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
commit-bot: I haz the power
No comments yet.
7 years, 7 months ago (2013-05-23 06:46:48 UTC) #1
umar.hansa
dbeam: Please review when you get a chance, thanks.
7 years, 7 months ago (2013-05-23 06:49:48 UTC) #2
umar.hansa
The lines of invalid CSS have been removed.
7 years, 7 months ago (2013-05-25 14:02:24 UTC) #3
PhistucK
Just make sure you update the commit log according to the new change. Thank you!
7 years, 7 months ago (2013-05-25 15:52:53 UTC) #4
umar.hansa
I think I have! $ git log shows this: commit 5075acc7ccba530da17b0f5d11e61695cdef4b19 Author: Umar Hansa <umar.hansa@gmail.com> ...
7 years, 7 months ago (2013-05-25 20:39:42 UTC) #5
PhistucK
On 2013/05/25 20:39:42, umar.hansa wrote: > I think I have! $ git log shows this: ...
7 years, 7 months ago (2013-05-26 16:02:52 UTC) #6
umar.hansa
On 2013/05/26 16:02:52, PhistucK wrote: > On 2013/05/25 20:39:42, umar.hansa wrote: > > I think ...
7 years, 7 months ago (2013-05-26 16:05:59 UTC) #7
Dan Beam
lgtm I know it's strange to take this route, it's annoying to introduce regressions from ...
7 years, 6 months ago (2013-05-29 03:13:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/umar.hansa@gmail.com/15823004/4001
7 years, 6 months ago (2013-05-29 03:13:14 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 07:44:16 UTC) #10
Message was sent while issue was closed.
Change committed as 202799

Powered by Google App Engine
This is Rietveld 408576698