Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 15822005: Remove omnibox_search_hint.(cc,h). (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove omnibox_search_hint.(cc,h). This code was added by Jay in r21438, but it isn't used anymore. So it's time to remove it now. BUG=80186 R=pkasting@chromium.org TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203857

Patch Set 1 #

Patch Set 2 : rm it #

Patch Set 3 : sync+rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -355 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/app/theme/default_100_percent/common/infobar_questionmark.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_100_percent/infobar_questionmark.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/infobar_questionmark.png View 1 Binary file 0 comments Download
D chrome/app/theme/default_200_percent/infobar_questionmark.png View 1 Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/app/theme/touch_100_percent/infobar_questionmark.png View 1 Binary file 0 comments Download
M chrome/browser/android/resource_id.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/omnibox_search_hint.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/omnibox_search_hint.cc View 1 2 1 chunk +0 lines, -263 lines 0 comments Download
M chrome/browser/ui/browser_tab_contents.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/functional/prefs.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
7 years, 7 months ago (2013-05-26 15:38:53 UTC) #1
Peter Kasting
I think this code is dead and we can nuke it entirely, but I'm not ...
7 years, 6 months ago (2013-05-29 04:21:00 UTC) #2
Peter Kasting
On 2013/05/29 04:21:00, Peter Kasting wrote: > I think this code is dead and we ...
7 years, 6 months ago (2013-05-29 17:52:58 UTC) #3
tfarina
I'll remove it. I'll ping you back when it's ready.
7 years, 6 months ago (2013-05-29 18:17:00 UTC) #4
tfarina
I'll remove it. I'll ping you back when it's ready.
7 years, 6 months ago (2013-05-29 18:17:00 UTC) #5
tfarina
Dead code removed, please take another look.
7 years, 6 months ago (2013-05-29 22:04:01 UTC) #6
Peter Kasting
Rad. LGTM
7 years, 6 months ago (2013-05-29 23:59:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15822005/19001
7 years, 6 months ago (2013-06-04 03:53:11 UTC) #8
tfarina
TBRing Lei for the rest of chrome. Changes are trivial.
7 years, 6 months ago (2013-06-04 04:00:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15822005/19001
7 years, 6 months ago (2013-06-04 04:02:23 UTC) #10
Lei Zhang
lgtm
7 years, 6 months ago (2013-06-04 04:22:31 UTC) #11
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 06:04:49 UTC) #12
Message was sent while issue was closed.
Change committed as 203857

Powered by Google App Engine
This is Rietveld 408576698