Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 15821006: Add UMA entries for web history UMA histograms. (Closed)

Created:
7 years, 7 months ago by Sergiu
Modified:
7 years, 6 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things)
Visibility:
Public.

Description

Add UMA entries for web history UMA histograms. https://codereview.chromium.org/12381081 added UMA histograms for the web history but no entries were added to the histograms.xml file. This CL fixes that. R=isherman@chromium.org BUG=177073 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202455

Patch Set 1 #

Total comments: 4

Patch Set 2 : More comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergiu
Please take a look. Thanks.
7 years, 7 months ago (2013-05-24 15:57:11 UTC) #1
jar (doing other things)
Steve/Alexei: Can you comment?
7 years, 7 months ago (2013-05-24 17:42:54 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/15821006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/15821006/diff/1/tools/metrics/histograms/histograms.xml#newcode8996 tools/metrics/histograms/histograms.xml:8996: web history. Please mention how this is sampled. Is ...
7 years, 7 months ago (2013-05-24 17:58:02 UTC) #3
Sergiu
https://codereview.chromium.org/15821006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/15821006/diff/1/tools/metrics/histograms/histograms.xml#newcode8996 tools/metrics/histograms/histograms.xml:8996: web history. On 2013/05/24 17:58:02, Alexei Svitkine wrote: > ...
7 years, 6 months ago (2013-05-27 08:27:43 UTC) #4
Alexei Svitkine (slow)
lgtm
7 years, 6 months ago (2013-05-27 15:14:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiu@chromium.org/15821006/6001
7 years, 6 months ago (2013-05-27 16:45:55 UTC) #6
jar (doing other things)
lgtm
7 years, 6 months ago (2013-05-27 16:49:53 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-27 18:51:03 UTC) #8
Message was sent while issue was closed.
Change committed as 202455

Powered by Google App Engine
This is Rietveld 408576698