Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 15820007: [content shell] simplify plugin whitelist. (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] simplify plugin whitelist. We only need the webkit test plugin during layout tests BUG=242291 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202545

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/shell/shell_plugin_service_filter.cc View 1 chunk +1 line, -5 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years, 7 months ago (2013-05-28 08:02:41 UTC) #1
Bernhard Bauer
LGTM https://codereview.chromium.org/15820007/diff/1/content/shell/shell_plugin_service_filter.cc File content/shell/shell_plugin_service_filter.cc (right): https://codereview.chromium.org/15820007/diff/1/content/shell/shell_plugin_service_filter.cc#newcode23 content/shell/shell_plugin_service_filter.cc:23: return plugin->name == ASCIIToUTF16("WebKit Test PlugIn"); I'm not ...
7 years, 6 months ago (2013-05-28 09:52:26 UTC) #2
jochen (gone - plz use gerrit)
On 2013/05/28 09:52:26, Bernhard Bauer wrote: > LGTM > > https://codereview.chromium.org/15820007/diff/1/content/shell/shell_plugin_service_filter.cc > File content/shell/shell_plugin_service_filter.cc (right): ...
7 years, 6 months ago (2013-05-28 09:54:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/15820007/1
7 years, 6 months ago (2013-05-28 09:55:01 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 13:43:11 UTC) #5
Message was sent while issue was closed.
Change committed as 202545

Powered by Google App Engine
This is Rietveld 408576698