Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: Source/core/html/shadow/SpinButtonElement.cpp

Issue 15820002: Page::chrome() should return a reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/PickerIndicatorElement.cpp ('k') | Source/core/inspector/InspectorInputAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/SpinButtonElement.cpp
diff --git a/Source/core/html/shadow/SpinButtonElement.cpp b/Source/core/html/shadow/SpinButtonElement.cpp
index aad5bbff386ef1514e816fde3f1129f9041f83e6..e9399ac0a4d771fb265e41bac0e3bc1c53d1d803 100644
--- a/Source/core/html/shadow/SpinButtonElement.cpp
+++ b/Source/core/html/shadow/SpinButtonElement.cpp
@@ -121,10 +121,8 @@ void SpinButtonElement::defaultEventHandler(Event* event)
if (Frame* frame = document()->frame()) {
frame->eventHandler()->setCapturingMouseEventsNode(this);
m_capturing = true;
- if (Page* page = document()->page()) {
- if (page->chrome())
- page->chrome()->registerPopupOpeningObserver(this);
- }
+ if (Page* page = document()->page())
+ page->chrome().registerPopupOpeningObserver(this);
}
}
UpDownState oldUpDownState = m_upDownState;
@@ -199,10 +197,8 @@ void SpinButtonElement::releaseCapture()
if (Frame* frame = document()->frame()) {
frame->eventHandler()->setCapturingMouseEventsNode(0);
m_capturing = false;
- if (Page* page = document()->page()) {
- if (page->chrome())
- page->chrome()->unregisterPopupOpeningObserver(this);
- }
+ if (Page* page = document()->page())
+ page->chrome().unregisterPopupOpeningObserver(this);
}
}
}
« no previous file with comments | « Source/core/html/shadow/PickerIndicatorElement.cpp ('k') | Source/core/inspector/InspectorInputAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698