Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

Issue 15820002: Page::chrome() should return a reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp b/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
index 6774f7c610d42efafa3b5ec23cdb7e8079e0d1fd..fc1d3589878dc3f5948412caea73ec69f96a31b2 100644
--- a/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
+++ b/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
@@ -759,14 +759,14 @@ Frame* FrameLoaderClientImpl::dispatchCreatePage(const NavigationAction& action)
// Store the disposition on the opener ChromeClientImpl so that we can pass
// it to WebViewClient::createView.
- ChromeClientImpl* chromeClient = static_cast<ChromeClientImpl*>(m_webFrame->frame()->page()->chrome()->client());
+ ChromeClientImpl* chromeClient = static_cast<ChromeClientImpl*>(m_webFrame->frame()->page()->chrome().client());
chromeClient->setNewWindowNavigationPolicy(policy);
if (m_webFrame->frame()->settings() && !m_webFrame->frame()->settings()->supportsMultipleWindows())
return m_webFrame->frame();
struct WindowFeatures features;
- Page* newPage = m_webFrame->frame()->page()->chrome()->createWindow(
+ Page* newPage = m_webFrame->frame()->page()->chrome().createWindow(
m_webFrame->frame(), FrameLoadRequest(m_webFrame->frame()->document()->securityOrigin()),
features, action);
@@ -805,7 +805,7 @@ PolicyAction FrameLoaderClientImpl::policyForNewWindowAction(
// Store the disposition on the opener ChromeClientImpl so that we can pass
// it to WebViewClient::createView.
- ChromeClientImpl* chromeClient = static_cast<ChromeClientImpl*>(m_webFrame->frame()->page()->chrome()->client());
+ ChromeClientImpl* chromeClient = static_cast<ChromeClientImpl*>(m_webFrame->frame()->page()->chrome().client());
chromeClient->setNewWindowNavigationPolicy(navigationPolicy);
return PolicyUse;
« no previous file with comments | « Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp ('k') | Source/WebKit/chromium/src/StorageNamespaceProxy.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698