Additions to the Android java-side Device Motion/Orientation fetching

Additions to the Android java-side Device Motion/Orientation fetching

A number of small modifications/improvements:
- add a getNumberActiveMotionSensors() to determine how many sensors could actually be activated for device motion
- make sure that the orientation events are only fired when the appropriate sensors change
- rename mAccelerationVector to mAccelerationIncludingGravityVector

BUG=135804
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206091

[timvolodine, 2013-06-12 17:04:35]

Hi Marcus,

Could you please have a look?

thanks,
Tim

[bulach, 2013-06-13 09:49:35]

lgtm, thanks! just nits:

https://codereview.chromium.org/15817019/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_impl_android.cc (right):

https://codereview.chromium.org/15817019/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_impl_android.cc:115: return
Java_DeviceMotionAndOrientation_getNumberActiveDeviceMotionSensors(
nit: for consistency,  DCHECK(!device_orientation_.is_null()); as the functions
above?

https://codereview.chromium.org/15817019/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(right):

https://codereview.chromium.org/15817019/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:51:
private float[] mAccelerationIncludingGravityVector;;
nit: double ;;

https://codereview.chromium.org/15817019/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:83:
int mNumberActiveDeviceMotionSensors = 0;
nit: seems unused

[timvolodine, 2013-06-13 14:00:40]

thanks!

https://codereview.chromium.org/15817019/diff/1/content/browser/device_orient...
File content/browser/device_orientation/data_fetcher_impl_android.cc (right):

https://codereview.chromium.org/15817019/diff/1/content/browser/device_orient...
content/browser/device_orientation/data_fetcher_impl_android.cc:115: return
Java_DeviceMotionAndOrientation_getNumberActiveDeviceMotionSensors(
On 2013/06/13 09:49:35, bulach wrote:
> nit: for consistency,  DCHECK(!device_orientation_.is_null()); as the
functions
> above?

Done.

https://codereview.chromium.org/15817019/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java
(right):

https://codereview.chromium.org/15817019/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:51:
private float[] mAccelerationIncludingGravityVector;;
On 2013/06/13 09:49:35, bulach wrote:
> nit: double ;;

Done.

https://codereview.chromium.org/15817019/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/DeviceMotionAndOrientation.java:83:
int mNumberActiveDeviceMotionSensors = 0;
On 2013/06/13 09:49:35, bulach wrote:
> nit: seems unused

Done.

[commit-bot: I haz the power, 2013-06-13 14:00:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/15817019/9001

[commit-bot: I haz the power, 2013-06-13 16:38:40]

Change committed as 206091