Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 15817002: Remove races in window creation in Files.app. (Closed)

Created:
7 years, 7 months ago by mtomasz
Modified:
7 years, 7 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Remove races in window creation in Files.app. This patch removes races in case of requested reusing of windows. It might happend, that windows are not yet fully initialized and we tried to reuse them. This bug is fixed by waiting for all windows to be initialized by enqueuing the reusing logic. TEST=Follow the bug's repro steps. BUG=238412 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202011

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 2

Patch Set 3 : Addressed comments. #

Patch Set 4 : Fixed. #

Patch Set 5 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -53 lines) Patch
M chrome/browser/resources/file_manager/js/background.js View 1 2 1 chunk +64 lines, -51 lines 0 comments Download
M chrome/browser/resources/file_manager/js/test_util.js View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 7 months ago (2013-05-23 06:33:01 UTC) #1
yoshiki
https://codereview.chromium.org/15817002/diff/2001/chrome/browser/resources/file_manager/js/background.js File chrome/browser/resources/file_manager/js/background.js (right): https://codereview.chromium.org/15817002/diff/2001/chrome/browser/resources/file_manager/js/background.js#newcode351 chrome/browser/resources/file_manager/js/background.js:351: }); In test_util.js, the retual value is used. Could ...
7 years, 7 months ago (2013-05-23 06:49:21 UTC) #2
mtomasz
On 2013/05/23 06:49:21, yoshiki wrote: > https://codereview.chromium.org/15817002/diff/2001/chrome/browser/resources/file_manager/js/background.js > File chrome/browser/resources/file_manager/js/background.js (right): > > https://codereview.chromium.org/15817002/diff/2001/chrome/browser/resources/file_manager/js/background.js#newcode351 > ...
7 years, 7 months ago (2013-05-23 06:50:41 UTC) #3
mtomasz
https://codereview.chromium.org/15817002/diff/2001/chrome/browser/resources/file_manager/js/background.js File chrome/browser/resources/file_manager/js/background.js (right): https://codereview.chromium.org/15817002/diff/2001/chrome/browser/resources/file_manager/js/background.js#newcode351 chrome/browser/resources/file_manager/js/background.js:351: }); On 2013/05/23 06:49:21, yoshiki wrote: > In test_util.js, ...
7 years, 7 months ago (2013-05-23 07:17:30 UTC) #4
yoshiki
lgtm
7 years, 7 months ago (2013-05-23 07:24:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/15817002/8001
7 years, 7 months ago (2013-05-23 07:35:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/15817002/16001
7 years, 7 months ago (2013-05-23 07:48:22 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=4552
7 years, 7 months ago (2013-05-23 07:58:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/15817002/22001
7 years, 7 months ago (2013-05-23 11:10:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=43107
7 years, 7 months ago (2013-05-23 20:10:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/15817002/22001
7 years, 7 months ago (2013-05-24 03:22:01 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-24 07:38:18 UTC) #12
Message was sent while issue was closed.
Change committed as 202011

Powered by Google App Engine
This is Rietveld 408576698