Supports unicode composition(Ctrl+Shift+U) with C-S pressed.

Supports unicode composition(Ctrl+Shift+U) with C-S pressed.

The current implementation does not support to input a hexadecimal sequence (e.g. 3042) with control and shift keys held pressed.  Users have to release control and shift keys first, and then users can input a hexadecimal sequence.

This CL supports to input a hexadecimal sequence while a user holds control and shift keys pressed.

This CL passes a keycode to CharacterComposer::FilterKeyPress() and let it guess what character would be inputted if a user had already released control and shift keys.

NOTE: If a user holds shift key pressed, hitting '3' key produces '#' (shift + 3).

BUG=126988
TEST=Type "u3042<enter>" with control and shift keys pressed.  "あ" will be composed.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202041

[Yuki, 2013-05-23 05:09:55]

Could you review this CL?

Thanks,
Yuki Shiino

[nona, 2013-05-23 07:29:47]

Will take a look, but please add nona@chromium.org instead of
nona@google.com.
Thank you.


2013/5/23 <yukishiino@chromium.org>

> Reviewers: nona,
>
> Message:
> Could you review this CL?
>
> Thanks,
> Yuki Shiino
>
>
> Description:
> Supports unicode composition(Ctrl+Shift+U) with C-S pressed.
>
> The current implementation does not support to input a hexadecimal sequence
> (e.g. 3042) with control and shift keys held pressed.  Users have to
> release
> control and shift keys first, and then users can input a hexadecimal
> sequence.
>
> This CL supports to input a hexadecimal sequence while a user holds
> control and
> shift keys pressed.
>
> This CL passes a keycode to CharacterComposer::**FilterKeyPress() and let
> it guess
> what character would be inputted if a user had already released control and
> shift keys.
>
> NOTE: If a user holds shift key pressed, hitting '3' key produces '#'
> (shift +
> 3).
>
> BUG=126988
> TEST=Type "u3042<enter>" with control and shift keys pressed.  "あ" will be
> composed.
>
> Please review this at
https://codereview.chromium.**org/15816003/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ui/base/ime/character_**composer.h
>   M ui/base/ime/character_**composer.cc
>   M ui/base/ime/character_**composer_unittest.cc
>   M ui/base/ime/input_method_ibus.**h
>   M ui/base/ime/input_method_ibus.**cc
>
>
>

[Yuki, 2013-05-23 07:33:29]

Sorry.  Changed to nona@chromium.org

[Seigo Nonaka, 2013-05-23 08:19:21]

Please take care of linux_chromeos_clang compile error.

https://codereview.chromium.org/15816003/diff/2001/ui/base/ime/character_comp...
File ui/base/ime/character_composer.cc (right):

https://codereview.chromium.org/15816003/diff/2001/ui/base/ime/character_comp...
ui/base/ime/character_composer.cc:356: Display* display = ::XOpenDisplay(NULL);
How about using MessagePumpAuraForUI::GetDefaultXDisplay.

[Yuki, 2013-05-23 08:48:40]

Thanks for the review.  Fixed.

https://codereview.chromium.org/15816003/diff/2001/ui/base/ime/character_comp...
File ui/base/ime/character_composer.cc (right):

https://codereview.chromium.org/15816003/diff/2001/ui/base/ime/character_comp...
ui/base/ime/character_composer.cc:356: Display* display = ::XOpenDisplay(NULL);
On 2013/05/23 08:19:21, Seigo Nonaka wrote:
> How about using MessagePumpAuraForUI::GetDefaultXDisplay.

Done.

[Seigo Nonaka, 2013-05-23 11:27:02]

lgtm

lgtm with one comment.

https://codereview.chromium.org/15816003/diff/14001/ui/base/ime/character_com...
File ui/base/ime/character_composer.cc (right):

https://codereview.chromium.org/15816003/diff/14001/ui/base/ime/character_com...
ui/base/ime/character_composer.cc:371: if (GDK_KEY_0 <= keyval && keyval <=
GDK_KEY_9)
Hmm this is not your fault but how about using XK_0,XK_9 instead?
Seems there is no GDK stuff except key symbol definitions, and incomming
keyvalue is result of XLookupKeysym, so that X11's key symbol table should be
used, I think.
No need to do this CL but please leave TODO.(leaving me is fine)

[commit-bot: I haz the power, 2013-05-24 06:10:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/15816003/18001

[Yuki, 2013-05-24 06:24:45]

Thanks, now committing.

https://codereview.chromium.org/15816003/diff/14001/ui/base/ime/character_com...
File ui/base/ime/character_composer.cc (right):

https://codereview.chromium.org/15816003/diff/14001/ui/base/ime/character_com...
ui/base/ime/character_composer.cc:371: if (GDK_KEY_0 <= keyval && keyval <=
GDK_KEY_9)
On 2013/05/23 11:27:03, Seigo Nonaka wrote:
> Hmm this is not your fault but how about using XK_0,XK_9 instead?
> Seems there is no GDK stuff except key symbol definitions, and incomming
> keyvalue is result of XLookupKeysym, so that X11's key symbol table should be
> used, I think.
> No need to do this CL but please leave TODO.(leaving me is fine)

Done.

[commit-bot: I haz the power, 2013-05-24 09:52:56]

Change committed as 202041