Remove unused includes from core/platform .cpp files

Remove unused includes from core/platform .cpp files

Splitting up codereview.chromium.org/15447002 into smaller patches.

BUG=242216
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151236

[jamesr, 2013-05-24 00:23:35]

Could you explain how you generated this patch and what the criteria for
#includes for this patch is?

[pdr., 2013-05-24 03:11:52]

On 2013/05/24 00:23:35, jamesr wrote:
> Could you explain how you generated this patch and what the criteria for
> #includes for this patch is?

Timothy has been generating these with IWYU and the output seems to be pretty
strict for just including what the file itself uses. I've been reviewing these
line-by-line to check.

[pdr., 2013-05-24 03:33:40]

LGTM with nits.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/CrossThr...
File Source/core/platform/CrossThreadCopier.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/CrossThr...
Source/core/platform/CrossThreadCopier.cpp:36: #include "core/platform/KURL.h"
I think IWYU got a bit overzealous with the KURL removal.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/Scrollab...
File Source/core/platform/ScrollableArea.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/Scrollab...
Source/core/platform/ScrollableArea.cpp:36: #include
"core/platform/PlatformWheelEvent.h"
This might still be used.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/chromium...
File Source/core/platform/chromium/GamepadsChromium.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/chromium...
Source/core/platform/chromium/GamepadsChromium.cpp:27: #include
"core/platform/Gamepads.h"
This might still be used.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/FontCache.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/FontCache.cpp:36: #include
"core/platform/graphics/FontPlatformData.h"
This looks like it's used.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/filters/FilterEffect.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/filters/FilterEffect.cpp:30: #include
"core/platform/text/TextStream.h"
This might still be used.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/leveldb/...
File Source/core/platform/leveldb/LevelDBDatabase.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/leveldb/...
Source/core/platform/leveldb/LevelDBDatabase.cpp:36: #include
"core/platform/Logging.h"
This might still be used.

[Timothy Loh, 2013-05-24 04:43:32]

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/CrossThr...
File Source/core/platform/CrossThreadCopier.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/CrossThr...
Source/core/platform/CrossThreadCopier.cpp:36: #include "core/platform/KURL.h"
On 2013/05/24 03:33:41, pdr wrote:
> I think IWYU got a bit overzealous with the KURL removal.

Yeah, it suggests to add weborigin/KURL.h. I've been manually re-adding these
but I must've missed it here. I have some code now that checks what I shouldn't
be removing though, so I shouldn't miss this one again :)

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/Scrollab...
File Source/core/platform/ScrollableArea.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/Scrollab...
Source/core/platform/ScrollableArea.cpp:36: #include
"core/platform/PlatformWheelEvent.h"
On 2013/05/24 03:33:41, pdr wrote:
> This might still be used.

Only needs a forward declaration, header has one.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/chromium...
File Source/core/platform/chromium/GamepadsChromium.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/chromium...
Source/core/platform/chromium/GamepadsChromium.cpp:27: #include
"core/platform/Gamepads.h"
On 2013/05/24 03:33:41, pdr wrote:
> This might still be used.

Fixed.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/FontCache.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/FontCache.cpp:36: #include
"core/platform/graphics/FontPlatformData.h"
On 2013/05/24 03:33:41, pdr wrote:
> This looks like it's used.

Fixed.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/filters/FilterEffect.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/filters/FilterEffect.cpp:30: #include
"core/platform/text/TextStream.h"
On 2013/05/24 03:33:41, pdr wrote:
> This might still be used.

Forward declaration in header.

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/leveldb/...
File Source/core/platform/leveldb/LevelDBDatabase.cpp (left):

https://codereview.chromium.org/15811002/diff/1/Source/core/platform/leveldb/...
Source/core/platform/leveldb/LevelDBDatabase.cpp:36: #include
"core/platform/Logging.h"
On 2013/05/24 03:33:41, pdr wrote:
> This might still be used.

Fixed.

[Timothy Loh, 2013-05-24 04:51:40]

On 2013/05/24 03:11:52, pdr wrote:
> On 2013/05/24 00:23:35, jamesr wrote:
> > Could you explain how you generated this patch and what the criteria for
> > #includes for this patch is?
> 
> Timothy has been generating these with IWYU and the output seems to be pretty
> strict for just including what the file itself uses. I've been reviewing these
> line-by-line to check.

I have a bit of python code for modifying the source files (IWYU's script will
try and fix everything and then nothing will compile). These patches are a
subset of all the removals/changes to includes that we can do. I'm starting this
off with includes that we can remove easily. Future patches will e.g. make use
of forward declarations, remove includes from headers and re-add them to
necessary cpp files.

[commit-bot: I haz the power, 2013-05-24 04:52:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/6001

[commit-bot: I haz the power, 2013-05-24 05:49:09]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-24 07:55:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/20001

[commit-bot: I haz the power, 2013-05-24 08:59:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-24 09:47:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/38001

[commit-bot: I haz the power, 2013-05-24 11:22:24]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-24 13:22:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/38001

[commit-bot: I haz the power, 2013-05-24 14:40:09]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-26 07:07:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/38001

[commit-bot: I haz the power, 2013-05-26 08:27:01]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 02:03:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/38001

[commit-bot: I haz the power, 2013-05-27 03:26:15]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-28 03:17:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/78001

[commit-bot: I haz the power, 2013-05-28 03:32:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/80001

[commit-bot: I haz the power, 2013-05-28 05:11:51]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-28 07:19:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/15811002/80001

[commit-bot: I haz the power, 2013-05-28 10:04:43]

Change committed as 151236