Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 15808007: Reland r202508: Made the open menu item in the context menu updated when the context menu is open. (Closed)

Created:
7 years, 6 months ago by hirono
Modified:
7 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Reland r202508: Made the open menu item in the context menu updated when the context menu is open. Original patch broke SelectFileAndOpen browser test. This is because Files.app notify 'selection-change-complete' to the tests even if the selection is empty. This CL is fixed the problem by adding a check of the number of selected items. Previously reverted CL: crrev.com/15950003 BUG=243687 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -53 lines) Patch
M chrome/browser/resources/file_manager/js/file_selection.js View 1 chunk +47 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hirono
@yoshiki-san, crrev.com/15950003 was reverted. Could you check the CL to reland this? Thank you!
7 years, 6 months ago (2013-05-29 01:53:41 UTC) #1
hirono
@yoshiki-san, crrev.com/15950003 was reverted. Could you check the CL to reland this? Thank you!
7 years, 6 months ago (2013-05-29 01:54:14 UTC) #2
yoshiki
lgtm
7 years, 6 months ago (2013-05-29 02:24:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15808007/1
7 years, 6 months ago (2013-05-29 02:24:42 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-05-29 02:55:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15808007/1
7 years, 6 months ago (2013-05-29 03:32:48 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 07:44:01 UTC) #7
Message was sent while issue was closed.
Change committed as 202798

Powered by Google App Engine
This is Rietveld 408576698