Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: Source/bindings/v8/PageScriptDebugServer.cpp

Issue 15806013: Use V8ScriptRunner::callInternalFunction in PageScriptDebugServer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/PageScriptDebugServer.cpp
diff --git a/Source/bindings/v8/PageScriptDebugServer.cpp b/Source/bindings/v8/PageScriptDebugServer.cpp
index 63340b4e672d5fc26fe4b48bfde9fbb97392e2c3..a96772be80cb144040b949999b098e043a13c80e 100644
--- a/Source/bindings/v8/PageScriptDebugServer.cpp
+++ b/Source/bindings/v8/PageScriptDebugServer.cpp
@@ -37,6 +37,7 @@
#include "bindings/v8/V8Binding.h"
#include "bindings/v8/V8DOMWindowShell.h"
#include "bindings/v8/V8RecursionScope.h"
+#include "bindings/v8/V8ScriptRunner.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "core/inspector/ScriptDebugListener.h"
#include "core/page/Frame.h"
@@ -99,11 +100,7 @@ void PageScriptDebugServer::addListener(ScriptDebugListener* listener, Page* pag
v8::Local<v8::Context> context = shell->context();
v8::Handle<v8::Function> getScriptsFunction = v8::Local<v8::Function>::Cast(m_debuggerScript.get()->Get(v8::String::NewSymbol("getScripts")));
v8::Handle<v8::Value> argv[] = { context->GetEmbedderData(0) };
- v8::Handle<v8::Value> value;
- {
- V8RecursionScope::MicrotaskSuppression scope;
- value = getScriptsFunction->Call(m_debuggerScript.get(), 1, argv);
- }
+ v8::Handle<v8::Value> value = V8ScriptRunner::callInternalFunction(getScriptsFunction, context, m_debuggerScript.get(), 1, argv, m_isolate);
abarth-chromium 2013/05/28 17:47:08 I'd use WTF_ARRAY_LENGTH macro rather than hard-co
if (value.IsEmpty())
return;
ASSERT(!value->IsUndefined() && value->IsArray());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698