Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 15806013: Use V8ScriptRunner::callInternalFunction in PageScriptDebugServer (Closed)

Created:
7 years, 6 months ago by haraken
Modified:
7 years, 6 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin
Visibility:
Public.

Description

Use V8ScriptRunner::callInternalFunction in PageScriptDebugServer This is one of steps to aggregate call sites of Function::Call. R=abarth,eseidel BUG=241743 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151356

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M Source/bindings/v8/PageScriptDebugServer.cpp View 2 chunks +2 lines, -5 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
haraken
r?
7 years, 6 months ago (2013-05-28 16:20:39 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/15806013/diff/1/Source/bindings/v8/PageScriptDebugServer.cpp File Source/bindings/v8/PageScriptDebugServer.cpp (right): https://codereview.chromium.org/15806013/diff/1/Source/bindings/v8/PageScriptDebugServer.cpp#newcode103 Source/bindings/v8/PageScriptDebugServer.cpp:103: v8::Handle<v8::Value> value = V8ScriptRunner::callInternalFunction(getScriptsFunction, context, m_debuggerScript.get(), 1, argv, ...
7 years, 6 months ago (2013-05-28 17:47:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/15806013/1
7 years, 6 months ago (2013-05-28 17:47:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7718
7 years, 6 months ago (2013-05-28 19:01:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/15806013/1
7 years, 6 months ago (2013-05-29 05:04:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7809
7 years, 6 months ago (2013-05-29 06:21:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/15806013/1
7 years, 6 months ago (2013-05-29 06:42:56 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 06:51:53 UTC) #8
Message was sent while issue was closed.
Change committed as 151356

Powered by Google App Engine
This is Rietveld 408576698