Issue 15806002: Files.app: Fixed a bug of moving multiple files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15806002: Files.app: Fixed a bug of moving multiple files. (Closed)

Created:
7 years, 7 months ago by hirono

Modified:
7 years, 7 months ago

Reviewers:
mtomasz, hirono

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Files.app: Fixed a bug of moving multiple files. In the situation that both a directory and its child item are moved, if the directory is moved first, we will lose the child item because its path is changed. This CL make the copy items sorted so as that items in the deeper directories moved faster than ones in the shallower directories. BUG=230755 TEST=Enable moving from search results and test manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201741

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_copy_manager.js	View		2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hirono

Could you check this CL? After this CL, we can enable 'copying/moving from search result ...

7 years, 7 months ago (2013-05-23 03:40:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15806002/1

7 years, 7 months ago (2013-05-23 04:08:25 UTC) #3

hirono

On 2013/05/23 04:07:43, mtomasz wrote: > lgtm, thanks! Thank you very much! I'll go the ...

7 years, 7 months ago (2013-05-23 04:08:27 UTC) #4

Message was sent while issue was closed.

Change committed as 201741

Expand Messages | Collapse Messages