Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: url/gurl.h

Issue 15805003: Make the copy of GURL in src/url buildable as a component build. (try 2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: more class level exports Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | url/url.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/gurl.h
===================================================================
--- url/gurl.h (revision 202256)
+++ url/gurl.h (working copy)
@@ -11,9 +11,10 @@
#include "base/string16.h"
#include "url/url_canon.h"
#include "url/url_canon_stdstring.h"
+#include "url/url_export.h"
#include "url/url_parse.h"
-class GURL {
+class URL_EXPORT GURL {
public:
typedef url_canon::StdStringReplacements<std::string> Replacements;
typedef url_canon::StdStringReplacements<string16> ReplacementsW;
@@ -32,10 +33,8 @@
// encode the query parameters. It is probably sufficient for the narrow
// version to assume the query parameter encoding should be the same as the
// input encoding.
- explicit GURL(const std::string& url_string
- /*, output_param_encoding*/);
- explicit GURL(const string16& url_string
- /*, output_param_encoding*/);
+ explicit GURL(const std::string& url_string /*, output_param_encoding*/);
+ explicit GURL(const string16& url_string /*, output_param_encoding*/);
// Constructor for URLs that have already been parsed and canonicalized. This
// is used for conversions from KURL, for example. The caller must supply all
@@ -361,6 +360,6 @@
};
// Stream operator so GURL can be used in assertion statements.
-std::ostream& operator<<(std::ostream& out, const GURL& url);
+URL_EXPORT std::ostream& operator<<(std::ostream& out, const GURL& url);
#endif // URL_GURL_H_
« no previous file with comments | « no previous file | url/url.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698