Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: tools/perf/perf_tools/memory_measurement.py

Issue 15804006: Remove --reduce-security-for-stats-collection-tests switch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/public/common/content_switches.cc ('k') | tools/perf/perf_tools/startup_measurement.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from perf_tools import histogram_metric 4 from perf_tools import histogram_metric
5 from telemetry.page import page_measurement 5 from telemetry.page import page_measurement
6 6
7 MEMORY_HISTOGRAMS = [ 7 MEMORY_HISTOGRAMS = [
8 {'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent'}, 8 {'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent'},
9 {'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb'}, 9 {'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb'},
10 {'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb'}, 10 {'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb'},
(...skipping 20 matching lines...) Expand all
31 def CustomizeBrowserOptions(self, options): 31 def CustomizeBrowserOptions(self, options):
32 options.AppendExtraBrowserArg('--enable-stats-collection-bindings') 32 options.AppendExtraBrowserArg('--enable-stats-collection-bindings')
33 # For a hard-coded set of Google pages (such as GMail), we produce custom 33 # For a hard-coded set of Google pages (such as GMail), we produce custom
34 # memory histograms (V8.Something_gmail) instead of the generic histograms 34 # memory histograms (V8.Something_gmail) instead of the generic histograms
35 # (V8.Something), if we detect that a renderer is only rendering this page 35 # (V8.Something), if we detect that a renderer is only rendering this page
36 # and no other pages. For this test, we need to disable histogram 36 # and no other pages. For this test, we need to disable histogram
37 # customizing, so that we get the same generic histograms produced for all 37 # customizing, so that we get the same generic histograms produced for all
38 # pages. 38 # pages.
39 options.AppendExtraBrowserArg('--disable-histogram-customizer') 39 options.AppendExtraBrowserArg('--disable-histogram-customizer')
40 options.AppendExtraBrowserArg('--memory-metrics') 40 options.AppendExtraBrowserArg('--memory-metrics')
41 options.AppendExtraBrowserArg(
42 '--reduce-security-for-stats-collection-tests')
43 41
44 # Old commandline flags used for reference builds. 42 # Old commandline flags used for reference builds.
45 options.AppendExtraBrowserArg('--dom-automation') 43 options.AppendExtraBrowserArg('--dom-automation')
46 options.AppendExtraBrowserArg( 44 options.AppendExtraBrowserArg(
47 '--reduce-security-for-dom-automation-tests') 45 '--reduce-security-for-dom-automation-tests')
48 46
49 def CanRunForPage(self, page): 47 def CanRunForPage(self, page):
50 return hasattr(page, 'stress_memory') 48 return hasattr(page, 'stress_memory')
51 49
52 def MeasurePage(self, page, tab, results): 50 def MeasurePage(self, page, tab, results):
53 for h in self.histograms: 51 for h in self.histograms:
54 h.GetValue(page, tab, results) 52 h.GetValue(page, tab, results)
55 53
56 if tab.browser.is_profiler_active('tcmalloc-heap'): 54 if tab.browser.is_profiler_active('tcmalloc-heap'):
57 # The tcmalloc_heap_profiler dumps files at regular 55 # The tcmalloc_heap_profiler dumps files at regular
58 # intervals (~20 secs). 56 # intervals (~20 secs).
59 # This is a minor optimization to ensure it'll dump the last file when 57 # This is a minor optimization to ensure it'll dump the last file when
60 # the test completes. 58 # the test completes.
61 tab.ExecuteJavaScript(""" 59 tab.ExecuteJavaScript("""
62 if (chrome && chrome.memoryBenchmarking) { 60 if (chrome && chrome.memoryBenchmarking) {
63 chrome.memoryBenchmarking.heapProfilerDump('final', 'renderer'); 61 chrome.memoryBenchmarking.heapProfilerDump('final', 'renderer');
64 chrome.memoryBenchmarking.heapProfilerDump('final', 'browser'); 62 chrome.memoryBenchmarking.heapProfilerDump('final', 'browser');
65 } 63 }
66 """) 64 """)
OLDNEW
« no previous file with comments | « content/public/common/content_switches.cc ('k') | tools/perf/perf_tools/startup_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698