Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 15797009: Make snapshot_unittests depend on allocator.gyp:allocator when necessary (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Make snapshot_unittests depend on allocator.gyp:allocator when necessary This fixes the heapchecker+components release build. BUG=241938 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/snapshot/snapshot.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+sky for review Probably will TBR eventually
7 years, 6 months ago (2013-05-29 23:22:08 UTC) #1
sky
LGTM - would be nice if there was a general way to specify this rather ...
7 years, 6 months ago (2013-05-29 23:39:43 UTC) #2
akalin
On 2013/05/29 23:39:43, sky wrote: > LGTM - would be nice if there was a ...
7 years, 6 months ago (2013-05-29 23:51:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/15797009/1
7 years, 6 months ago (2013-05-29 23:51:31 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 03:44:55 UTC) #5
Message was sent while issue was closed.
Change committed as 203046

Powered by Google App Engine
This is Rietveld 408576698