Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 15796006: Make ProxyResolver not use to-be-deprecated V8 functions. (Closed)

Created:
7 years, 7 months ago by marja
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Make ProxyResolver not use to-be-deprecated V8 functions. This gets rid of more places where Persistent handles are copied (see bug). BUG=236290 TBR=eroman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202418

Patch Set 1 #

Patch Set 2 : code review (dcarney) #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M net/proxy/proxy_resolver_v8.cc View 1 2 4 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
marja
dcarney, could you review this? (I'll ask an OWNER to rubberstamp if this lgty.)
7 years, 7 months ago (2013-05-24 15:09:40 UTC) #1
dcarney
lgtm, after discussed contextscope fix
7 years, 7 months ago (2013-05-27 07:56:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/15796006/3001
7 years, 7 months ago (2013-05-27 09:07:27 UTC) #3
marja
TBRing eroman@ again since this is adapting proxy_resolver to v8 api changes again.
7 years, 7 months ago (2013-05-27 09:23:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/15796006/7001
7 years, 7 months ago (2013-05-27 09:23:44 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-27 09:56:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/15796006/7001
7 years, 7 months ago (2013-05-27 10:22:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=118662
7 years, 7 months ago (2013-05-27 12:17:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/15796006/7001
7 years, 7 months ago (2013-05-27 12:18:15 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-27 13:59:30 UTC) #10
Message was sent while issue was closed.
Change committed as 202418

Powered by Google App Engine
This is Rietveld 408576698