[MediaStream API] Adding MediaStreamTrack::getSourceInfos

[MediaStream API] Adding MediaStreamTrack::getSourceInfos
This patch adds the functionality to list which webcams/micophones are available.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151839

[Tommy Widenflycht, 2013-05-24 14:07:24]

Hi,
This patch is missing tests but I wanted a early review to make sure I have
understood correctly the new way of interacting with the webkit API.
Thanks.

[abarth-chromium, 2013-05-24 16:53:50]

Yeah, generally looks like the right approach.

https://codereview.chromium.org/15796004/diff/1/Source/modules/mediastream/Me...
File Source/modules/mediastream/MediaStreamTrack.idl (right):

https://codereview.chromium.org/15796004/diff/1/Source/modules/mediastream/Me...
Source/modules/mediastream/MediaStreamTrack.idl:41:
[CallWith=ScriptExecutionContext, RaisesException] static sequence<SourceInfo>
getSourceInfos();
Is this really how this is defined in the spec?

https://codereview.chromium.org/15796004/diff/1/public/platform/WebSourceInfo.h
File public/platform/WebSourceInfo.h (right):

https://codereview.chromium.org/15796004/diff/1/public/platform/WebSourceInfo...
public/platform/WebSourceInfo.h:74: #endif
IF this section is empty, we can remove it.

[Tommy Widenflycht, 2013-05-27 14:17:50]

https://codereview.chromium.org/15796004/diff/1/Source/modules/mediastream/Me...
File Source/modules/mediastream/MediaStreamTrack.idl (right):

https://codereview.chromium.org/15796004/diff/1/Source/modules/mediastream/Me...
Source/modules/mediastream/MediaStreamTrack.idl:41:
[CallWith=ScriptExecutionContext, RaisesException] static sequence<SourceInfo>
getSourceInfos();
On 2013/05/24 16:53:50, abarth wrote:
> Is this really how this is defined in the spec?

yes (or will be as soon as the next editors draft will be pushed out)

https://codereview.chromium.org/15796004/diff/1/public/platform/WebSourceInfo.h
File public/platform/WebSourceInfo.h (right):

https://codereview.chromium.org/15796004/diff/1/public/platform/WebSourceInfo...
public/platform/WebSourceInfo.h:74: #endif
On 2013/05/24 16:53:50, abarth wrote:
> IF this section is empty, we can remove it.

Done.

[Tommy Widenflycht, 2013-05-31 12:51:18]

abarth: Could you please take another look?

[abarth-chromium, 2013-05-31 17:30:08]

LGTM

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/chro...
File Source/core/platform/chromium/support/WebSourceInfo.cpp (right):

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/chro...
Source/core/platform/chromium/support/WebSourceInfo.cpp:41: WebString id() const
{ return m_id; }
These can return const WebString&

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
File Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.cpp
(right):

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.cpp:75:
return m_private ? m_private->getSourceInfos(url, sourceInfos) : false;
A slightly more idiomatic way of doing this is:

return m_private && m_private->getSourceInfos(url, sourceInfos);

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
File Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.h
(right):

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.h:54: class
MediaStreamCenterChromium : public MediaStreamCenter, public
WebKit::WebMediaStreamCenterClient {
We probably don't need to distinguish MediaStreamCenterChromium from
MediaStreamCenter anymore.  :)

[Tommy Widenflycht, 2013-06-05 11:51:38]

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/chro...
File Source/core/platform/chromium/support/WebSourceInfo.cpp (right):

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/chro...
Source/core/platform/chromium/support/WebSourceInfo.cpp:41: WebString id() const
{ return m_id; }
On 2013/05/31 17:30:08, abarth wrote:
> These can return const WebString& 

Done.

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
File Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.cpp
(right):

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.cpp:75:
return m_private ? m_private->getSourceInfos(url, sourceInfos) : false;
On 2013/05/31 17:30:08, abarth wrote:
> A slightly more idiomatic way of doing this is:
> 
> return m_private && m_private->getSourceInfos(url, sourceInfos);

Done.

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
File Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.h
(right):

https://codereview.chromium.org/15796004/diff/21001/Source/core/platform/medi...
Source/core/platform/mediastream/chromium/MediaStreamCenterChromium.h:54: class
MediaStreamCenterChromium : public MediaStreamCenter, public
WebKit::WebMediaStreamCenterClient {
On 2013/05/31 17:30:08, abarth wrote:
> We probably don't need to distinguish MediaStreamCenterChromium from
> MediaStreamCenter anymore.  :)

Nah, I'll fix it in a followup patch.

[commit-bot: I haz the power, 2013-06-05 11:52:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/15796004/28001

[commit-bot: I haz the power, 2013-06-05 13:26:21]

Change committed as 151839